Issue #71: Group #265
Issue #71: Group #265
Conversation
…ll Command timeout to 15 mins, remove app-manager`s intermediate state`s timeout
…t direct conversion
…vice_version = "default"
…cannot trigger the device-config updating's bug in some cases
… immediately during the check loop
# Conflicts: # src/Cargo.lock # src/component/cyfs-base/src/objects/any.rs # src/component/cyfs-lib/src/lib.rs # src/meta/cyfs-meta/src/creator.rs # src/tools/desc-tool/src/modify.rs
| @@ -10,6 +10,49 @@ message StorageBodyContent { | |||
| bytes value = 1; | |||
| } | |||
|
|
|||
| // ObjectShellObject | |||
| message ObjectShellDescContent { | |||
There was a problem hiding this comment.
I'm sorry, I have commit it with the feature #71 .
There was a problem hiding this comment.
There should be a corresponding English readme
There was a problem hiding this comment.
Ok, I'll translate it.
There was a problem hiding this comment.
Now the group mechanism has not designed a proper acl?
There was a problem hiding this comment.
No acl now. and it need a new discussion.
| handler.clone(), | ||
| )); | ||
|
|
||
| server.at("group/push-proposal").put(Self::new( |
There was a problem hiding this comment.
It should be "/group/push-proposal"
There was a problem hiding this comment.
The http protocol of rcp is recommended to use RESTFUL, not to have actions on the path, but to use method to identify, so the two paths of group will be better designed as the following
POST /group/service
POST /group/proposal
There was a problem hiding this comment.
thank you, I will update it.
| @@ -127,6 +127,40 @@ impl DeviceInfoManagerImpl { | |||
| } | |||
| } | |||
|
|
|||
| async fn verfiy_group_own_signs( | |||
There was a problem hiding this comment.
The so-called "checksign" looks like it's just comparing hash values?
There was a problem hiding this comment.
Thanks, I will rename it.
| } | ||
| } | ||
|
|
||
| async fn put_object(&self, dec_id: &ObjectId, obj: NONObjectInfo) -> BuckyResult<()> { |
There was a problem hiding this comment.
Why not just use sync_std::future::timeout instead of relying on the select of futures, which is obviously more complicated?
There was a problem hiding this comment.
I want to hold the life of the future to continue. and start a new future to retry at the same time. maybe the first future is slow only.
| rpath: rpath.to_string(), | ||
| }; | ||
|
|
||
| self.encode_common_headers(NONAction::PutObject, &req_common, &mut http_req); |
There was a problem hiding this comment.
For group services NONAction field are not unnecessary and can be removed
lurenpluto
added
Group
| com_req.req_path.as_deref(), | ||
| ); | ||
|
|
||
| http_req.insert_header(CYFS_API_LEVEL, com_req.level.to_string()); |
There was a problem hiding this comment.
api level is non/ndn relatively obsolete design, for the group this function this should not be necessary
| } | ||
|
|
||
| pub(crate) fn make_default_common(dec_id: ObjectId) -> NONOutputRequestCommon { | ||
| NONOutputRequestCommon { |
There was a problem hiding this comment.
Here it is recommended that group-related interfaces have a separate RequestCommon, even if it is completely consistent with NON's, it is better to redefine it
pub type GroupRequestCommon = NONRequestCommon;
There was a problem hiding this comment.
Thank you, you are right, I will define a new structure, the usefull field is only dec_id now. others will be add when it's used.
No description provided.